Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the send_keys helper work in selenium as well as cuprite #3328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iainbeeston
Copy link
Contributor

@iainbeeston iainbeeston commented Oct 10, 2024

Description

A few of the test helpers use the type helper method but in selenium it raises this error:

 NoMethodError:
   undefined method `keyboard' for #<Selenium::WebDriver::Chrome::Driver:0x000000013ebbb950>

I've changed this to do the same thing (type in the focused element) but in a way that should work in every capybara driver.

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Tests using add_tag and other helpers that use the keyboard should still pass.

Manual reviewer: please leave a comment with output from the test if that's the case.

A few of the test helpers use the `type` helper method but in selenium it raises this error:

     NoMethodError:
       undefined method `keyboard' for #<Selenium::WebDriver::Chrome::Driver:0x000000013ebbb950>

I've changed this to do the same thing (type in the focused element) but in a way that should work in every capybara driver.
Copy link

codeclimate bot commented Oct 10, 2024

Code Climate has analyzed commit 9be468c and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant